Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Person Page: Corrects 'Articles by Person' Section Full Name Missing Space #1309

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

patrickbrown-io
Copy link
Contributor

Resolves #1306

@timurtripp
Copy link
Member

Can you grab just the value instead of the full rendered output? Prevents the itemprop from being on the page twice

@timurtripp
Copy link
Member

Also same newline problem can happen with "by" and the first name.

Copy link
Member

@timurtripp timurtripp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@timurtripp timurtripp merged commit ced77a7 into main Sep 18, 2024
2 checks passed
@timurtripp timurtripp deleted the issue/1306 branch September 18, 2024 19:05
github-actions bot pushed a commit that referenced this pull request Sep 18, 2024
Person Page: Corrects 'Articles by Person' Section Full Name Missing Space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Articles by Person no space between first and last name
2 participants