Skip to content

Commit

Permalink
Merge pull request #1211 from CuBoulder/issue/1207
Browse files Browse the repository at this point in the history
Article List: Fixes Exclusion Filters
  • Loading branch information
jcsparks authored and web-flow committed Aug 14, 2024
2 parents c855fd5 + e8c7a9b commit fd7db47
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

- ### Article List: Fixes Exclusion Filters
### Article List
Fixes a bug with the `Article List` introduced when we refactored Article Lists to strictly enforce chronological order despite API timings. The bug would cause exclusions to throw an API Error instead of skipping processing entirely, which they had done when chronological order was not strictly enforced.

This has been corrected and Articles flagged with Excluded Categories / Excluded Tags are properly removed with an additional check.

Resolves #1207
---

- ### New Image Styles: Colorbox Image Styles
### New Image Styles
Adds 4 new colorbox image styles: `Colorbox Small` , `Colorbox Small Square`, `Colorbox Small Thumbnail`, `Colorbox Square`. On click, these open up a modal with the full image and caption.
Expand Down
5 changes: 4 additions & 1 deletion js/ucb-article-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,17 @@

let results = await Promise.all(promises);

results.forEach(result => {
results
.filter(result => result !== undefined)
.forEach(result => {
let dataOutput = document.getElementById("ucb-al-data");
let thisArticle = document.createElement("article");
thisArticle.className = 'ucb-article-card-container';
thisArticle.appendChild(result.articleRow);
dataOutput.append(thisArticle);
});


if (NEXTJSONURL) {
toggleMessage('ucb-el-load-more', 'inline-block');
}
Expand Down

0 comments on commit fd7db47

Please sign in to comment.