Merge pull request #597 from CuBoulder/issue/596

Fixes error on Newsletter pages
CuBoulder · Dec 19, 2023 · 8d870e4 · 8d870e4
2 parents 6f0da10 + 96d28ea
commit 8d870e4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+- ### Fixes error on Newsletter pages
+  Resolves CuBoulder/tiamat-theme#596
+---
+
 - ### Fixes Embedded Video not displaying, if also Aligned
   Adds a custom CSS override to Embedded Videos, if also aligned via CKeditor5, in order to prevent a visual bug where they becoming hidden if floated left/right or centered on a rendered page. This bug was caused by our customized embedded video style and the default alignments (left,right,center) conflicting. 
 

diff --git a/templates/content/node--newsletter.html.twig b/templates/content/node--newsletter.html.twig
@@ -13,17 +13,19 @@
   'node--type-' ~ node.bundle|clean_class,
   not node.isPublished() ? 'node--unpublished',
   view_mode ? 'node--view-mode-' ~ view_mode|clean_class,
-]% }
+] %}
 
 {# Dummy variable to ensure that all content tags are set for caching purposes #}
 {% set content_render = content|render %}
 
 <article{{ attributes.addClass(classes) }}>
   <div{{ create_attribute({
-	'class': ['container', 'ucb-newsletter'],
-	'data-loggedin': logged_in ? 'true' : 'false' }) }}>
+    'class': ['container', 'ucb-newsletter'],
+    'data-loggedin': logged_in ? 'true' : 'false' }) }}>
     {# Newsletter Title #}
-    <h1 class="ucb-newsletter-title {{isFrontPage}}" itemprop="name">{{ label }}</h1>
+    <h1{{ title_attributes.addClass('ucb-newsletter-title', is_front ? 'sr-only').setAttribute('itemprop', 'name') }}>
+      {{ label }}
+    </h1>
     {# Newsletter Intro #}
     {% if content.field_newsletter_intro_image|render %}
       <div id="newsletter-intro-img">{{ content.field_newsletter_intro_image }}</div>