Timer format #142
Open
Timer format #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crystalwarrior
requested changes
May 26, 2024
server/commands/roleplay.py
Outdated
| current_time = int(timer.static.total_seconds()) * 1000 | ||
| for area in areas: | ||
| for c in area.clients: | ||
| c.send_command("TF", args[0], args[1], current_time) |
There was a problem hiding this comment.
Maybe re-use send_timer_set_time instead?
|
Oh yeah-- can you also add a documentation/commands.md entry and any aliases to the config_sample? |
|
Okay I've added stuff to command aliases and to documentation |
not perfect, but it still tells people the proper notation
heckin github auto-formatted the Ctrl+V
| timer = self.area.area_manager.timer | ||
| else: | ||
| timer = self.area.timers[timer_id-1] | ||
| self.send_command("TF", timer_id, timer.format, new_time) |
There was a problem hiding this comment.
does DRO support timer formatting or is this just a KFO-Client feature we came up with? I'll double-check.
Crystalwarrior
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.