Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2283 Make the Language Filter SearchBar sticky #3425

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

frett
Copy link
Contributor

@frett frett commented Mar 20, 2024

  • lift the languages menu expanded boolen out of the LanguagesFilter
  • add a couple paparazzi tests for the LanguageFilter
  • make the searchbar sticky for the languages filter menu

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 78.37838% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 36.76%. Comparing base (c8a3ccd) to head (b725ed1).

Files Patch % Lines
...org/cru/godtools/ui/dashboard/tools/ToolFilters.kt 74.07% 3 Missing and 4 partials ⚠️
.../cru/godtools/ui/dashboard/tools/ToolsPresenter.kt 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3425      +/-   ##
===========================================
- Coverage    36.76%   36.76%   -0.01%     
===========================================
  Files          446      446              
  Lines        10882    10891       +9     
  Branches      2454     2455       +1     
===========================================
+ Hits          4001     4004       +3     
- Misses        6170     6179       +9     
+ Partials       711      708       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett merged commit 30cc3e6 into develop Mar 21, 2024
13 checks passed
@frett frett deleted the GT-2283-Filter-Language-Search-Bar branch March 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants