Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup Paparazzi for composable screenshot tests #3407

Merged
merged 3 commits into from
Mar 11, 2024
Merged

Conversation

frett
Copy link
Contributor

@frett frett commented Mar 7, 2024

Paparazzi provides us the ability to validate UIs against golden values to detect when a UI changes due to a change we make.

This will hopefully provide stability for our UIs as we update underlying data models and rendering logic.
Also, when we make an intentional change to a UI component, it should be possible to preview the actual UI differences during code review.

@frett frett force-pushed the setupPaparazzi branch 4 times, most recently from e1cbe6c to c90e53d Compare March 7, 2024 23:49
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 59.09091% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 37.18%. Comparing base (077825f) to head (c451908).
Report is 2 commits behind head on develop.

Files Patch % Lines
.../cru/godtools/base/ui/compose/CompositionLocals.kt 0.00% 4 Missing ⚠️
.../downloadable/LanguageDownloadProgressIndicator.kt 81.25% 1 Missing and 2 partials ⚠️
...in/org/cru/godtools/base/ui/theme/GodToolsTheme.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3407      +/-   ##
===========================================
+ Coverage    36.90%   37.18%   +0.28%     
===========================================
  Files          446      446              
  Lines        10850    10857       +7     
  Branches      2465     2467       +2     
===========================================
+ Hits          4004     4037      +33     
+ Misses        6130     6095      -35     
- Partials       716      725       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frett frett force-pushed the setupPaparazzi branch 2 times, most recently from e51b81a to 422e303 Compare March 8, 2024 00:36
@frett
Copy link
Contributor Author

frett commented Mar 8, 2024

@aaronlaib this might be of interest to you and Jill, you can see screenshots of the various UI elements that paparazzi is tracking here.

@frett frett merged commit 23c41ae into develop Mar 11, 2024
13 checks passed
@frett frett deleted the setupPaparazzi branch March 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants