Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dagger to v2.51 #3387

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Update dagger to v2.51 #3387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1743fa1
Update dagger to v2.51
renovate[bot] Mar 1, 2024
b71201a
change visibility of injected fields
frett Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ androidx-room = "2.6.1"
androidx-viewpager2 = "1.0.0"
androidx-work = "2.9.0"
circuit = "0.19.1"
dagger = "2.50"
dagger = "2.51"
eventbus = "3.3.1"
facebook = "16.3.0"
facebook-flipper = "0.247.0"
Expand Down
2 changes: 1 addition & 1 deletion ui/base-tool/src/main/kotlin/org/cru/godtools/base/tool/activity/BaseToolActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ import org.greenrobot.eventbus.ThreadMode
abstract class BaseToolActivity<B : ViewDataBinding>(@LayoutRes contentLayoutId: Int) :
BaseBindingActivity<B>(contentLayoutId) {
@Inject
protected lateinit var downloadManager: GodToolsDownloadManager
lateinit var downloadManager: GodToolsDownloadManager
@Inject
@Named(IS_CONNECTED_LIVE_DATA)
internal lateinit var isConnected: LiveData<Boolean>
Expand Down
4 changes: 2 additions & 2 deletions ui/base/src/main/kotlin/org/cru/godtools/base/ui/activity/BaseActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ internal const val MSG_FEATURE_DISCOVERY = 1

abstract class BaseActivity protected constructor() : AppCompatActivity() {
@Inject
protected lateinit var eventBus: EventBus
lateinit var eventBus: EventBus
@Inject
protected lateinit var settings: Settings
lateinit var settings: Settings

// region Lifecycle
override fun onCreate(savedInstanceState: Bundle?) {
Expand Down
2 changes: 1 addition & 1 deletion ui/cyoa-renderer/src/main/kotlin/org/cru/godtools/tool/cyoa/ui/CyoaPageFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import splitties.fragmentargs.arg
abstract class CyoaPageFragment<B : ViewDataBinding, C : BaseController<*>>(@LayoutRes layoutId: Int, page: String?) :
BaseFragment<B>(layoutId), ShowTipCallback {
@Inject
protected lateinit var eventBus: EventBus
internal lateinit var eventBus: EventBus

protected val dataModel by activityViewModels<MultiLanguageToolActivityDataModel>()
internal val toolState by activityViewModels<ToolStateHolder>()
Expand Down