Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2178 Add Support for a user deleting their account #3220

Merged
merged 8 commits into from
Nov 13, 2023
Merged

Conversation

frett
Copy link
Contributor

@frett frett commented Nov 9, 2023

Create a new Delete Account UI using Slack Circuit

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #3220 (621eb67) into develop (c5aa0bb) will increase coverage by 0.36%.
Report is 2 commits behind head on develop.
The diff coverage is 59.86%.

@@             Coverage Diff             @@
##           develop    #3220      +/-   ##
===========================================
+ Coverage    32.83%   33.20%   +0.36%     
===========================================
  Files          432      439       +7     
  Lines        10606    10753     +147     
  Branches      2335     2377      +42     
===========================================
+ Hits          3483     3571      +88     
- Misses        6563     6607      +44     
- Partials       560      575      +15     
Files Coverage Δ
...org/cru/godtools/account/GodToolsAccountManager.kt 60.00% <100.00%> (+6.51%) ⬆️
...pi/src/main/kotlin/org/cru/godtools/api/UserApi.kt 0.00% <ø> (ø)
.../godtools/ui/account/delete/DeleteAccountScreen.kt 88.88% <88.88%> (ø)
...dtools/ui/account/delete/DeleteAccountPresenter.kt 86.95% <86.95%> (ø)
...in/kotlin/org/cru/godtools/dagger/CircuitModule.kt 0.00% <0.00%> (ø)
...lin/org/cru/godtools/ui/drawer/DrawerMenuLayout.kt 29.55% <0.00%> (-1.16%) ⬇️
.../godtools/ui/account/delete/DeleteAccountModule.kt 0.00% <0.00%> (ø)
...s/ui/account/delete/DeleteAccountLayout+Preview.kt 0.00% <0.00%> (ø)
...odtools/ui/account/delete/DeleteAccountActivity.kt 0.00% <0.00%> (ø)
.../godtools/ui/account/delete/DeleteAccountLayout.kt 76.38% <76.38%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@frett frett marked this pull request as ready for review November 10, 2023 23:18
@frett frett requested a review from gyasistory November 10, 2023 23:18
@frett frett merged commit df95e5b into develop Nov 13, 2023
12 checks passed
@frett frett deleted the deleteAccount branch November 13, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants