Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-1796 Track which tools were added/removed as favorites #3110

Merged
merged 4 commits into from
Sep 20, 2023

Conversation

frett
Copy link
Contributor

@frett frett commented Sep 19, 2023

  • track changed fields on the ToolEntity
  • support tracking changes to the isFavorite property via pinTool
  • don't track changes when initializing favorites
  • update unpinTool to track changes

@frett frett changed the title GT-1796 Track which tools were added/removed as favorites locally GT-1796 Track which tools were added/removed as favorites Sep 19, 2023
@frett frett requested a review from gyasistory September 19, 2023 20:44
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #3110 (3085d96) into develop (c461929) will increase coverage by 0.06%.
Report is 5 commits behind head on develop.
The diff coverage is 66.66%.

@@             Coverage Diff             @@
##           develop    #3110      +/-   ##
===========================================
+ Coverage    31.29%   31.36%   +0.06%     
===========================================
  Files          421      423       +2     
  Lines        10306    10331      +25     
  Branches      2288     2295       +7     
===========================================
+ Hits          3225     3240      +15     
- Misses        6543     6551       +8     
- Partials       538      540       +2     
Files Changed Coverage Δ
...tlin/org/cru/godtools/model/ChangeTrackingModel.kt 0.00% <0.00%> (ø)
...del/src/main/kotlin/org/cru/godtools/model/Tool.kt 46.51% <66.66%> (+0.08%) ⬆️
...godtools/db/room/repository/ToolsRoomRepository.kt 87.50% <71.42%> (-5.10%) ⬇️
.../org/cru/godtools/db/repository/ToolsRepository.kt 100.00% <100.00%> (ø)
...n/org/cru/godtools/db/room/GodToolsRoomDatabase.kt 75.00% <100.00%> (ø)
...tlin/org/cru/godtools/db/room/entity/ToolEntity.kt 98.70% <100.00%> (+0.07%) ⬆️
...ru/godtools/db/room/entity/partial/ToolFavorite.kt 100.00% <100.00%> (ø)
...kotlin/org/cru/godtools/init/content/task/Tasks.kt 30.58% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@frett frett force-pushed the trackChangedFields branch from a7d7253 to 3085d96 Compare September 20, 2023 15:38
@frett frett merged commit 81137ef into develop Sep 20, 2023
12 checks passed
@frett frett deleted the trackChangedFields branch September 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants