-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP-2261: BCO Premium Selection #927
base: master
Are you sure you want to change the base?
Conversation
feea844
to
8112460
Compare
There are still several references to radio station codes. |
8112460
to
4555d6f
Compare
Feel free to merge it to staging locally after Travis passes here. |
@wrandall22 I was working on Mike's request for an anchor on branded-checkout-step-1 to jump to the Premium section. I was having some difficulty with this, and it might not be the highest priority right now, but I did notice that the user's choice for the Premium selection was getting overwritten when navigating back to branded-checkout-step-1. I made an update here to make sure that the choice the user made will still appear when reversing steps. Do you think I should still attempt to get the anchoring to work? |
As far as anchoring...None of the other |
I think part of the reason is that the branded checkout component has to load, and the anchoring probably happens before it loads completely, so anchoring into some HTML that doesn't yet exist will likely have issues. |
Yes, when I saw that the sections of the checkout screen passed unique string values to |
I think that functionality is more used on standard checkout, where those steps are actually on different pages. |
dc981ca
to
7ea0922
Compare
7ea0922
to
0adf54f
Compare
After I resolve the conflicts and rebase this on top of master, should I go ahead and merge this? John will need this to add the premium functionality to the plugin. |
Is the plugin on stage pointing at the production branded checkout? That would be problematic... |
@wrandall22 I guess I misunderstood what John told me earlier today. He is able to work with Premiums on staging, and the plugin on staging uses the staging Branded Checkout. He was wondering why the Premium attributes were not in the README on production, but I think he has what he needs to work on this. Do you think I should merge this in still? Or do we want to wait and see if FamilyLife wants the placement of the Premium fields to be changed? |
I think we should wait for their feedback on placement. |
The last 2 commits could have their descriptions improved. What is happening in those commits is not what is described by the commit messages. |
9a1fc94
to
e623f0a
Compare
Thanks for making those updates! If you get these changes out on staging that will be helpful (if you haven't already). |
@wrandall22 it is on staging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found a couple minor things while implementing AEM piece.
Allows users to select a premium on branded checkout