Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP-2261: BCO Premium Selection #927

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

reldredge71
Copy link
Contributor

Allows users to select a premium on branded checkout

@wrandall22
Copy link
Contributor

There are still several references to radio station codes.

@wrandall22 wrandall22 added the On Staging Will be merged to the staging branch by Github Actions label Aug 18, 2021
@wrandall22 wrandall22 removed the On Staging Will be merged to the staging branch by Github Actions label Aug 20, 2021
@wrandall22
Copy link
Contributor

Feel free to merge it to staging locally after Travis passes here.

@reldredge71 reldredge71 added the On Staging Will be merged to the staging branch by Github Actions label Aug 20, 2021
@reldredge71
Copy link
Contributor Author

@wrandall22 I was working on Mike's request for an anchor on branded-checkout-step-1 to jump to the Premium section. I was having some difficulty with this, and it might not be the highest priority right now, but I did notice that the user's choice for the Premium selection was getting overwritten when navigating back to branded-checkout-step-1. I made an update here to make sure that the choice the user made will still appear when reversing steps.

Do you think I should still attempt to get the anchoring to work?

@wrandall22
Copy link
Contributor

As far as anchoring...None of the other Change buttons go to a particular part of the page, outside of just the branded checkout component itself. That might be worth mentioning to Mike. It would be a new pattern not followed by the rest of the branded checkout.

@wrandall22
Copy link
Contributor

I think part of the reason is that the branded checkout component has to load, and the anchoring probably happens before it loads completely, so anchoring into some HTML that doesn't yet exist will likely have issues.

@reldredge71
Copy link
Contributor Author

Yes, when I saw that the sections of the checkout screen passed unique string values to changeStep, it made me think that anchoring was possible... then I realized that none of the sections had that functionality yet. I agree that timing the anchor navigation with the loading of the screen would be tricky. I can mention that to Mike.

@wrandall22
Copy link
Contributor

I think that functionality is more used on standard checkout, where those steps are actually on different pages.

@reldredge71
Copy link
Contributor Author

After I resolve the conflicts and rebase this on top of master, should I go ahead and merge this? John will need this to add the premium functionality to the plugin.

@wrandall22
Copy link
Contributor

Is the plugin on stage pointing at the production branded checkout? That would be problematic...

@reldredge71
Copy link
Contributor Author

@wrandall22 I guess I misunderstood what John told me earlier today. He is able to work with Premiums on staging, and the plugin on staging uses the staging Branded Checkout. He was wondering why the Premium attributes were not in the README on production, but I think he has what he needs to work on this.

Do you think I should merge this in still? Or do we want to wait and see if FamilyLife wants the placement of the Premium fields to be changed?

@wrandall22
Copy link
Contributor

I think we should wait for their feedback on placement.

README.md Outdated Show resolved Hide resolved
src/app/branded/branded-checkout.tpl.html Show resolved Hide resolved
src/app/checkout/step-3/step-3.tpl.html Outdated Show resolved Hide resolved
src/app/checkout/step-3/step-3.tpl.html Show resolved Hide resolved
@caleballdrin caleballdrin self-assigned this Nov 12, 2024
@wrandall22
Copy link
Contributor

The last 2 commits could have their descriptions improved. What is happening in those commits is not what is described by the commit messages.

@wrandall22
Copy link
Contributor

Thanks for making those updates! If you get these changes out on staging that will be helpful (if you haven't already).

@caleballdrin
Copy link
Contributor

@wrandall22 it is on staging

Copy link
Contributor

@wrandall22 wrandall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple minor things while implementing AEM piece.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants