I like your breadcrumbs #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a title, then the breadcrumbs display a title. You have an optional viewname. So you can show the breadcrumbs for /index or for /manage There is a much simpler introduction. Just do BasicBredcrumbs(item,request).render() Of if that is not the right simple abstractin, the docs breaks down the way to split it up. Anyhow you did a beatuful job on this repository, as you have done on the rest of Cromlech.
There are a fwe things we need to discuss. I use the wrong resolver. Is it api compatible with the old version. Anything else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Much nicer than the ones I wrote. The best way to understand them is to document them.