don't need to unnecessary item meta edits for setting the max stack size

I was fixing the issue in the wrong place.
Crazy-Crew · Jul 12, 2024 · c9242ba · c9242ba
1 parent 044d071
commit c9242ba
Showing 1 changed file with 6 additions and 44 deletions.
diff --git a/src/main/java/com/badbones69/crazycrates/api/objects/Crate.java b/src/main/java/com/badbones69/crazycrates/api/objects/Crate.java
@@ -530,28 +530,15 @@ public final CrateType getCrateType() {
      * @return the key as an item stack.
      */
     public @NotNull final ItemStack getKey(Player player) {
-        final ItemStack itemStack = this.userManager.addPlaceholders(this.keyBuilder.setPlayer(player), this).getStack();
-
-        if (itemStack.hasItemMeta()) {
-            itemStack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-        }
-
-        return itemStack;
+        return this.userManager.addPlaceholders(this.keyBuilder.setPlayer(player), this).getStack();
     }
 
     /**
      * @param amount The amount of keys you want.
      * @return the key as an item stack.
      */
     public @NotNull final ItemStack getKey(int amount) {
-        final ItemStack itemStack = this.keyBuilder.getStack();
-        itemStack.setAmount(amount);
-
-        if (itemStack.hasItemMeta()) {
-            itemStack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-        }
-
-        return itemStack;
+        return this.keyBuilder.setAmount(amount).getStack();
     }
 
     /**
@@ -560,14 +547,7 @@ public final CrateType getCrateType() {
      * @return the key as an item stack.
      */
     public @NotNull final ItemStack getKey(int amount, Player player) {
-        final ItemStack itemStack = this.userManager.addPlaceholders(this.keyBuilder.setPlayer(player), this).getStack();
-        itemStack.setAmount(amount);
-
-        if (itemStack.hasItemMeta()) {
-            itemStack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-        }
-
-        return itemStack;
+        return this.userManager.addPlaceholders(this.keyBuilder.setPlayer(player), this).setAmount(amount).getStack();
     }
 
     /**
@@ -831,13 +811,7 @@ public final int getAbsolutePreviewItemPosition(final int baseSlot) {
         ArrayList<ItemStack> items = new ArrayList<>();
 
         for (final Prize prize : getPrizes()) {
-            ItemStack stack = prize.getDisplayItem();
-
-            if (stack.hasItemMeta()) {
-                stack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-            }
-
-            items.add(stack);
+            items.add(prize.getDisplayItem());
         }
 
         return items;
@@ -852,13 +826,7 @@ public final int getAbsolutePreviewItemPosition(final int baseSlot) {
         List<ItemStack> items = new ArrayList<>();
 
         for (final Prize prize : getPrizes()) {
-            ItemStack stack = prize.getDisplayItem(player);
-
-            if (stack.hasItemMeta()) {
-                stack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-            }
-
-            items.add(stack);
+            items.add(prize.getDisplayItem(player));
         }
 
         return items;
@@ -875,13 +843,7 @@ public final int getAbsolutePreviewItemPosition(final int baseSlot) {
 
         for (final Prize prize : getPrizes()) {
             if (prize.getTiers().contains(tier)) {
-                ItemStack stack = prize.getDisplayItem(player);
-
-                if (stack.hasItemMeta()) {
-                    stack.editMeta(itemMeta -> itemMeta.setMaxStackSize(64));
-                }
-
-                prizes.add(stack);
+                prizes.add(prize.getDisplayItem(player));
             }
         }