Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide support for weekdays in timeperiods in PyNag format #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide support for weekdays in timeperiods in PyNag format #14

wants to merge 1 commit into from

Conversation

akimboyko
Copy link

@akimboyko akimboyko commented Jan 18, 2017 •
edited
Loading

Hi @Crapworks,

Here is an update for RESTlos validate function to support weekdays in timeperiods in the format supported by 0.9.1.1 version of PyNag.

For example:

[
  {
    "alias": "monday_and_friday_are_workdays",
    "name": "monday_and_friday_are_workdays",
    "timeperiod_name": "monday_and_friday_are_workdays",
    "monday              06:00-11:00": "",
    "monday              12:30-15:00": "",
    "monday              17:30-22:30": "",
    "friday              00:00-12:00": "",
    "friday              13:00-22:00": "",
    "friday              23:05-23:25": ""
  }
]

It is not a real workaround for that as it is not based on PyNag object_definitions. However, it is good enough for our internal purposes.

Other types such as days of generic months, days of specific months, and calendar dates could be supported also if there will be interest by the community

akimboyko
akimboyko commented Jan 18, 2017
View reviewed changes
restlosapi.py
@@ -55,6 +56,13 @@ class ApiEndpoints(dict):

main_cfg_values = {}

timeperiod_regex = re.compile(
'^(monday|tuesday|wednesday|thursday|friday|saturday|sunday)'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an initial version provides support for weekdays only

akimboyko
akimboyko commented Jan 18, 2017
View reviewed changes
restlosapi.py
def validate(self, endpoint, data={}):
for attr in data.keys():
if endpoint == 'timeperiod':
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actual solution based on suggestion: use an if statement evereywhere to treat Timeperoids special from pynag issue 243

@CharlesJUDITH CharlesJUDITH mentioned this pull request Jan 31, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@akimboyko