Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rho statistics: Flexible use of either training or test star sample #636

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Rho statistics: Flexible use of either training or test star sample #636

wants to merge 2 commits into from

Conversation

martinkilbinger
Copy link
Contributor

Summary

Right now the rho statistics use the test star sample by default.
This also adds features to use the training set.

Do not merge yet.

Reviewer Checklist

  • The PR targets the develop branch
  • The PR is assigned to the developer
  • The PR has appropriate labels
  • The PR is included in appropriate projects and/or milestones
  • The PR includes a clear description of the proposed changes
  • If the PR addresses an open issue the description includes "closes #"
  • The code and documentation style match the current standards
  • Documentation has been added/updated consistently with the code
  • All CI tests are passing
  • API docs have been built and checked at least once (if relevant)
  • All changed files have been checked and comments provided to the developer
  • All of the reviewer's comments have been satisfactorily addressed by the developer

@martinkilbinger martinkilbinger added the enhancement New feature or request label Jul 3, 2023
@martinkilbinger martinkilbinger added this to the Re-run 2023 milestone Jul 3, 2023
@martinkilbinger martinkilbinger self-assigned this Jul 3, 2023
@martinkilbinger martinkilbinger mentioned this pull request Jul 3, 2023
Open
@sfarrens sfarrens marked this pull request as draft September 6, 2023 07:55
@sfarrens sfarrens removed this from the P3 re-run 2023 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@martinkilbinger martinkilbinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinkilbinger @sfarrens