Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #24

Merged
merged 3 commits into from
Jul 12, 2024
Merged

Bugfixes #24

merged 3 commits into from
Jul 12, 2024

Conversation

hubert-leterme
Copy link
Contributor

  • Bugfixes in mass_mapping.py (inconsistencies between array shapes)
  • Method sparse_wiener_filtering: previous commit #139f491 caused an error in the shape of intermediate arrays xg, xs and xw: initialization should be placed after the block if PropagateNoise. I also initialized xg in the if Inpaint block; otherwise there were an undeclared variable in self.get_resi. I think this is the reason why commit #139f491 was created in the first place.
  • Error corrections when calling method: get_lmax_dct_inpaint: it should take shear maps as arguments, not convergence maps.

Hubert Leterme added 3 commits July 10, 2024 09:50
- Move array initialization
- Method `get_lmax_dct_inpaint` takes shear maps as inputs, not convergence maps
- Method `sparse_wiener_filtering`: initialize array before `get_lmax_dct_inpaint`
@hubert-leterme hubert-leterme added the bug Something isn't working label Jul 10, 2024
@hubert-leterme hubert-leterme self-assigned this Jul 10, 2024
@hubert-leterme hubert-leterme merged commit 59c649d into CosmoStat:master Jul 12, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant