Adds testing of multiplicative biases against ngmix #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added numdifftools to the test environment
…ostat/autometacal into u/andrevitorelli/test_metacal_ngmix
EiffL
reviewed
Mar 29, 2022
.github/workflows/main.yml
Outdated
| @@ -52,7 +52,7 @@ jobs: | |||
| galsim \ | |||
| ngmix | |||
|
|
|||
| python -m pip install tensorflow==2.5.0 tensorflow_addons==0.13.0 tensorflow_probability==0.13.0 | |||
| python -m pip install tensorflow==2.5.0 tensorflow_addons==0.13.0 tensorflow_probability==0.13.0 numdifftools | |||
There was a problem hiding this comment.
It's not used in this test, but in the other. I don't think there is a problem in being here.
There was a problem hiding this comment.
we shouldnd't add dependencies that are not neeeded
I don't know if we need to be that careful with PRs in code that is in this early stage, tbh. There is a lot here that will eventually change for a working output. |
EiffL
reviewed
Mar 29, 2022
Co-authored-by: Francois Lanusse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing this test is what we need to solve issue #36