Adds testing script to compare against ngmix #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@andrevitorelli could you add as an option to this script to run autometacal in "finite diff" mode? This is quite useful actually to figure out where problems can come from. |
Yes, sure. I have it coded in a separate but local branch. Later today I'll push this to origin. But, just as a comment, I reintroduced my finitediff function to the |
…testing Adds finite differences testing within autometacal to ngmix tests
|
@EiffL , I'll close this as soon as I output individual shape measurements from the finitediff function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a comparison to https://github.com/esheldon/ngmix/blob/9910e9297525d6fafb9a41fac43a91b5d4ef4b37/examples/metacal/metacal.py
Also reverts back to standard ellipticity definition for easier direct comparison to ngmix