Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start Column IDs with 1 #79

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Start Column IDs with 1 #79

merged 3 commits into from
Oct 30, 2024

Conversation

uint
Copy link
Collaborator

@uint uint commented Oct 23, 2024

Closes #73

@uint uint force-pushed the 73-start-column-ids-with-1 branch from 3734360 to 252678e Compare October 23, 2024 19:43
webmaster128
webmaster128 reviewed Oct 30, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thanks

Could you document the new behaviour in push, which I guess can be seen as the place of key generation? Also showing that availability of the index in the example code would be good.

packages/storey/src/containers/column.rs Outdated Show resolved Hide resolved
webmaster128
webmaster128 approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@uint uint merged commit f53b3a7 into main Oct 30, 2024
2 checks passed
@uint uint deleted the 73-start-column-ids-with-1 branch October 30, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Start Column IDs from 1 instead of 0
2 participants
@uint @webmaster128