fix: ignore expired allowances on execute_increase_allowance and execute_decrease_allowance #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haryunio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
execute_increase_allowanceincludes expired allowances when calculating the new increased allowance, which might cause the allowance to increase more than intended.For example, after allowance of 10,000 is expired, increasing 5,000 will cause the allowance to become 15,000.
This should be fixed, so I added simple filtering logic in it.
This issue also mentions same problem
Issue #909
execute_decrease_allowancealso has same issue and written in different code style - so applied some changes on it too.