-
Notifications
You must be signed in to change notification settings - Fork 337
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve performance of destructing objects
We used to throw a NotImplemented exception, but this causes the c++ runtime to allocate on the heap. We can call zend_objects_destroy_object directly in the Php::Base::__destroy method instead. If someone overrides this method, then zend_objects_destroy_object will not be called, which is the behavior we had before as well.
- Loading branch information
Showing
2 changed files
with
5 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters