Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dialog to screenshot a proposal #173

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

chadbrower0
Copy link
Contributor

When the proposal is expanded, an extra button is added next to edit and delete buttons, which opens the screenshot dialog. The dialog offers options to choose which part of the proposal to screenshot (opinions vs reasons). The dialog also has buttons to copy the screenshot or the URL to clipboard. (Copy to clipboard is not well tested, because only https and localhost domains have access to clipboard API.)

@tkriplean
Copy link
Member

Again, this is awesome. I can imagine this functionality to be very useful to hosts. I can also imagine it being useful to save a screenshot of a list of proposals.

A few notes:

  • The edit/delete buttons don't appear for frozen forums, and thus the screenshot functionality doesn't appear (but it is useful for frozen forums)
  • The screenshot functionality will only be available for a host. However, it seems like it might be useful for anyone. Not sure though, keeping the clutter down is nice.
  • (I don't entirely love the edit / delete buttons as they exist, so we might want a different UI approach there entirely)
  • The screenshot doesn't copy the background color
  • It takes a little while for the screenshot to be available in the dialog. In the meantime, a bunch of errors are logged.
  • Copying to clipboard only copies the url, not the image (at least for me!). However, I could right-click on the image preview and save it.
  • I'm wondering it a download button instead of copy to clipboard button would make more sense.
errors

@chadbrower0
Copy link
Contributor Author

Added a white background-color fill.

@chadbrower0
Copy link
Contributor Author

I changed the dialog to offer checkboxes that customize which content to include. And I added logic to filter out content that is always unwanted, like various buttons.

image

@chadbrower0
Copy link
Contributor Author

Restyled screenshot dialog for more consistency with main webpage.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants