Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update RPCs - starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract to handle new txn state #458

Conversation

stanleyyconsensys
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys commented Dec 10, 2024

This PR is to update RPCs - starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract to handle new txn state

Requirements:

Below PRs has to merged before hand:

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner December 10, 2024 08:42
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and jonesho and removed request for a team December 10, 2024 08:42
@stanleyyconsensys stanleyyconsensys changed the base branch from main to feat/refactor-list-transactions-with-starkscan December 10, 2024 08:43
@stanleyyconsensys stanleyyconsensys changed the title Chore: update RPCs - starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract to handle new txn state chore: update RPCs - starkNet_createAccount , starkNet_createAccountLegacy, starkNet_upgradeAccContract to handle new txn state Dec 10, 2024
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
9.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stanleyyconsensys stanleyyconsensys merged commit 6619c62 into feat/refactor-list-transactions-with-starkscan Dec 11, 2024
14 checks passed
@stanleyyconsensys stanleyyconsensys deleted the chore/update-rpcs-handle-new-txn-state branch December 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants