-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update RPCs - starkNet_createAccount
, starkNet_createAccountLegacy
, starkNet_upgradeAccContract
to handle new txn state
#458
Merged
stanleyyconsensys
merged 47 commits into
feat/refactor-list-transactions-with-starkscan
from
chore/update-rpcs-handle-new-txn-state
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
December 10, 2024 08:42
stanleyyconsensys
changed the base branch from
main
to
feat/refactor-list-transactions-with-starkscan
December 10, 2024 08:43
stanleyyconsensys
changed the title
Chore: update RPCs -
chore: update RPCs - Dec 10, 2024
starkNet_createAccount
, starkNet_createAccountLegacy
, starkNet_upgradeAccContract
to handle new txn statestarkNet_createAccount
, starkNet_createAccountLegacy
, starkNet_upgradeAccContract
to handle new txn state
khanti42
requested changes
Dec 10, 2024
…ore/update-rpcs-handle-new-txn-state
Quality Gate passed for 'consensys_starknet-snap-wallet-ui'Issues Measures |
Quality Gate passed for 'consensys_starknet-snap-starknet-snap'Issues Measures |
khanti42
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
stanleyyconsensys
merged commit Dec 11, 2024
6619c62
into
feat/refactor-list-transactions-with-starkscan
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update RPCs -
starkNet_createAccount
,starkNet_createAccountLegacy
,starkNet_upgradeAccContract
to handle new txn stateRequirements:
Below PRs has to merged before hand:
starkNet_executeTxn
#457