chore: revamp RPC starkNet_getTransactionStatus
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Akaryatrh and
wantedsystem
and removed request for
a team
|
|
khanti42
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to revamp the RPC starkNet_getTransactionStatus handler to align with new RPC standard
this PR also remove the mocha test of
starkNet_getTransactionStatusandstarkNet_getTransactionsbecause of removal of starkNet_getTransactionStatus,
the mocha test of starkNet_getTransactions has to either fix or remove,
due to fade out of mocha test, remove of the test is easier than fix it
BEGIN_COMMIT_OVERRIDE
feat: Refactor RPC starkNet_getTransactionStatus to have superstruct validation (#447)
END_COMMIT_OVERRIDE