Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test report path and fix typo in Java code #1591

Open
wants to merge 3 commits into
base: arith-dev
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reference-blockchain-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
if: always()
uses: actions/upload-artifact@v4
with:
name: blockchain-refrence-tests-report
name: blockchain-reference-tests-report
path: reference-tests/build/reports/tests/**/*

- name: Failure Notification
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* correctly trigger other modules from the Hub.
*/
public class ImcFragment implements TraceFragment, ContextReEntryDefer {
/** the list of modules to trigger withing this fragment. */
/** the list of modules to trigger within this fragment. */
private final List<TraceSubFragment> moduleCalls = new ArrayList<>(5);

private final Hub hub;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
* account creation) and (I believe) no memory expansion the net upfront gas cost of this STATICCALL
* is 100. The current context is therefore left with 3024 gas after having paid for the upfront gas
* cost. The STATICCALL allows the transfer of all its GAS (=3124) to the child context. That is: it
* allows it to transfer (after upfronts costs) all 3024 remaing units of gas.
* allows it to transfer (after upfronts costs) all 3024 remaining units of gas.
*
* <p>However, the (63/64)-ths rule kicks in and the child may only receive 3024 - (3024/64) = 3024
* - 47 = 2977 to its child. With the cost of ECRECOVER being set at 3000 ECRECOVER fails in the
Expand Down