CREATE tests
#1572
Open
CREATE tests
#1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes GAS_NEXT issues for now
OlivierBBB
force-pushed
the
CREATE-tests
branch
from
59c91cd
to
581a7ab
Compare
OlivierBBB
commented
Dec 2, 2024
| @@ -206,6 +206,7 @@ public CreateSection(Hub hub, MessageFrame frame) { | |||
| if (failedCreate) { | |||
| finalContextFragment = ContextFragment.nonExecutionProvidesEmptyReturnData(hub); | |||
| scenarioFragment.setScenario(CREATE_FAILURE_CONDITION_WONT_REVERT); | |||
| commonValues.payGasPaidOutOfPocket(hub); | |||
OlivierBBB
commented
Dec 2, 2024
| preOpcodeCreateeSnapshot, | ||
| preOpcodeCreateeSnapshot, | ||
| preOpcodeCreatorSnapshot, | ||
| preOpcodeCreatorSnapshot, |
OlivierBBB
commented
Dec 2, 2024
| currentAddress, | ||
| salt, | ||
| hash, | ||
| longToUnsignedBigInteger(frame.getWorldUpdater().get(currentAddress).getNonce())); |
There was a problem hiding this comment.
Even though it's unnecessary, the nonce is part of the HUB -> RLPADDR lookup for CREATE2.
OlivierBBB
commented
Dec 2, 2024
| @@ -134,6 +142,7 @@ private void traceCreate2(int stamp, RlpAddrOperation chunk, Trace trace) { | |||
| .saltLo(chunk.salt().orElseThrow().slice(LLARGE, LLARGE)) | |||
| .kecHi(chunk.keccak().orElseThrow().slice(0, LLARGE)) | |||
| .kecLo(chunk.keccak().orElseThrow().slice(LLARGE, LLARGE)) | |||
| .nonce(nonceBytes) | |||
There was a problem hiding this comment.
We trace the nonce in all cases.
OlivierBBB
commented
Dec 2, 2024
| Address address, | ||
| Bytes32 salt, | ||
| Bytes32 kec, | ||
| BigInteger nonce) { |
There was a problem hiding this comment.
Adding the nonce to the interface
OlivierBBB
commented
Dec 2, 2024
| } | ||
|
|
||
| long gasMinusUpfront = currentGas - upfrontGasCost; | ||
| return gasMinusUpfront - gasMinusUpfront / 64; |
There was a problem hiding this comment.
This was a genuine mistake. the 63/64-ths business happens after paying the upfront gas cost.
OlivierBBB
commented
Dec 2, 2024
|
|
||
| final long gasMinusUpfrontGasCost = currentGas - upfrontGasCost; | ||
|
|
||
| return gasMinusUpfrontGasCost - gasMinusUpfrontGasCost / 64; |
There was a problem hiding this comment.
Same mistake for CREATE2
OlivierBBB
commented
Dec 2, 2024
| public ToyAccount raiseNonceBy(long k) { | ||
| long updatedNonce = this.getNonce() + k; | ||
| return new ToyAccount(this.parent, this.getAddress(), updatedNonce, this.balance, this.balance); | ||
| } |
This was
linked to
issues
Dec 2, 2024
We unconditionally import account.nonce() to the RLPADDR module. We must therefore also include the nonce to disambiguate duplicate CREATE2's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.