fix: enable previously disabled tests #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a number of previously disabled tests which actually pass. This also tidies up the naming of some of the regular tests.
DavePearce
force-pushed
the
1551-feat-enable-disabled-tests
branch
from
1e0db86
to
986e514
Compare
This disable remaining tests which actually still use too much resource for `go-corset`. Potentially, we should be considering some kind of graceful exit when this happens. Situations where it gets stuck: (1) Actually reading the trace file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a number of previously disabled tests which actually pass.