Skip to content

Commit

Permalink
Fixes for GeneralStateTests
Browse files Browse the repository at this point in the history
This puts through two minor fixes for the GeneralStateTests.  Firstly,
it adds notifications from the Rust corset side.  Secondly, it drops
parallelism from the go-corset side.
  • Loading branch information
DavePearce committed Nov 28, 2024
1 parent 0e1c9e6 commit 2e6e43f
Showing 1 changed file with 11 additions and 2 deletions.
13 changes: 11 additions & 2 deletions .github/workflows/gradle-ethereum-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,15 @@ jobs:
reference-tests/build/reports/tests/**/*
tmp/local/*
- name: Failure Notification
if: ${{ failure() || cancelled() }}
uses: slackapi/[email protected]
with:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: webhook-trigger
payload: |
name: "Daily Reference Tests (Rust Corset)"
status: "${{ job.status }}"
ethereum-tests-go-corset:
runs-on: ubuntu-latest-128
Expand All @@ -73,7 +82,7 @@ jobs:
run: cd ./linea-constraints; make zkevm_for_reference_tests.bin -B; cd ..

- name: Generate General State Reference Tests
run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.parallel=true -Dorg.gradle.caching=true
run: ./gradlew generateGeneralStateReferenceTests -Dorg.gradle.caching=true
env:
JAVA_OPTS: -Dorg.gradle.daemon=false
CORSET_FLAGS: fields,expand,expand,expand
Expand Down Expand Up @@ -101,5 +110,5 @@ jobs:
webhook: ${{ secrets.SLACK_WEBHOOK_URL }}
webhook-type: webhook-trigger
payload: |
name: "Daily Reference Tests"
name: "Daily Reference Tests (Go Corset)"
status: "${{ job.status }}"

0 comments on commit 2e6e43f

Please sign in to comment.