-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: remove geth dependency #440
Conversation
needs to be updated after Consensys/gnark-crypto#313 and Consensys/gnark-crypto#314 get merged in gnark-cypto. |
So, right now there is a slight problem - when we sign with gnark-crypto, as a signature we get a I have some ideas and will try to push the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased on top of develop, added a few more changes (avoid explicit conversion to *big.Int, rename package import, update go.mod).
Previously I totally overthought it. I think the simple approach is better (read signature directly into secp256k1 ECDSA signature struct and get R and S from there).
As far as it seems then the failing tests are due to MiMC hashing. Imo are unrelated to this PR.
Use gnark-crypto instead of geth/crypto for secp256k1 and ecdsa.
This needs Consensys/gnark-crypto#310 to be merged first.