Skip to content
This repository has been archived by the owner on Feb 3, 2024. It is now read-only.

Add reporting and quote hiding #60

Merged

Conversation

mxmeinhold
Copy link
Contributor

@mxmeinhold mxmeinhold commented Apr 23, 2021

Defines database migrations, and adds report functionality and quote hiding.

Requirements:

  • Define database migrations and updated schema
  • Add quote hiding
  • Add report functionality
  • Add admin interface
  • Add quote hiding button on the storage page for: speaker, submitter, eboard, rtp

Nice to have:

  • Notify of new reports by email or by slack

Resolves #58, resolves #47

@jabbate19
Copy link
Collaborator

Upon a report, who would it go to? Is there a single email for this to go to or would it have to be sent to all individual RTP/Eboard emails?

@mxmeinhold
Copy link
Contributor Author

I believe eboard@ would work. I can check once power is back.

Report Button allows quote to be sent to RTP/Eboard for review
Hide prevents the quote from being seen by anyone except for speaker, submitter, and Eboard/RTPs
Review is the process that Eboard/RTP view reported quotes to decide to keep or hide
@jabbate19 jabbate19 force-pushed the reporting-and-hiding branch 2 times, most recently from 4eb6958 to 038b3f2 Compare November 10, 2021 05:37
quotefault/mail.py Show resolved Hide resolved
quotefault/ldap.py Outdated Show resolved Hide resolved
@WillNilges WillNilges marked this pull request as ready for review November 11, 2021 23:55
Copy link
Member

@Mstrodl Mstrodl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, look at my comments tho

config.sample.py Outdated Show resolved Hide resolved
quotefault/templates/bootstrap/hidden.html Show resolved Hide resolved
quotefault/templates/bootstrap/storage.html Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@Mstrodl
Copy link
Member

Mstrodl commented Nov 12, 2021

@jabbate19 can we get some screenshots??

@jabbate19
Copy link
Collaborator

I accidentally deleted my config.py with all the creds in it, so I can't really load anything to take screenshots

Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a few documentation-oriented things, but I didn't see anything egregious. 🙃

migrations/README Outdated Show resolved Hide resolved
migrations/env.py Show resolved Hide resolved
quotefault/__init__.py Show resolved Hide resolved
quotefault/ldap.py Outdated Show resolved Hide resolved
quotefault/mail.py Show resolved Hide resolved
@jabbate19
Copy link
Collaborator

All corrections except for the pinning versions should be corrected as of 5685680

Copy link
Contributor Author

@mxmeinhold mxmeinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider this to be requesting changes. I can't leave review statuses since this is my PR.

cc @Mstrodl @WillNilges please don't merge this

alembic.ini Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
@WillNilges WillNilges self-requested a review November 12, 2021 16:22
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jabbate19 Please look at and correct @mxmeinhold's comments.

migrations/README Outdated Show resolved Hide resolved
migrations/README Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/templates/bootstrap/admin.html Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Outdated Show resolved Hide resolved
quotefault/__init__.py Show resolved Hide resolved
quotefault/templates/mail/report.html Outdated Show resolved Hide resolved
migrations/README Outdated Show resolved Hide resolved
@jabbate19
Copy link
Collaborator

#62
#61

Follow up issues to this PR for anyone to take

Pylint Caused Things to break

Left a debug
Add Report Review Path

Fix Docstring Wording for LDAP

Documentation/Formatting Correction

Wording and Error Handling Corrections
@jabbate19 jabbate19 force-pushed the reporting-and-hiding branch from 9d89c6c to a3cb5fb Compare November 17, 2021 03:41
Copy link
Member

@WillNilges WillNilges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

quotefault/models.py Show resolved Hide resolved
quotefault/models.py Show resolved Hide resolved
@mxmeinhold mxmeinhold merged commit 440c721 into ComputerScienceHouse:master Nov 17, 2021
@mxmeinhold mxmeinhold deleted the reporting-and-hiding branch November 17, 2021 04:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No database revisioning Can't delete a quote
4 participants