-
Notifications
You must be signed in to change notification settings - Fork 19
Add reporting and quote hiding #60
Add reporting and quote hiding #60
Conversation
Upon a report, who would it go to? Is there a single email for this to go to or would it have to be sent to all individual RTP/Eboard emails? |
I believe eboard@ would work. I can check once power is back. |
Report Button allows quote to be sent to RTP/Eboard for review Hide prevents the quote from being seen by anyone except for speaker, submitter, and Eboard/RTPs Review is the process that Eboard/RTP view reported quotes to decide to keep or hide
4eb6958
to
038b3f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, look at my comments tho
@jabbate19 can we get some screenshots?? |
I accidentally deleted my config.py with all the creds in it, so I can't really load anything to take screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a few documentation-oriented things, but I didn't see anything egregious. 🙃
All corrections except for the pinning versions should be corrected as of 5685680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider this to be requesting changes. I can't leave review statuses since this is my PR.
cc @Mstrodl @WillNilges please don't merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jabbate19 Please look at and correct @mxmeinhold's comments.
Pylint Caused Things to break Left a debug
Add Report Review Path Fix Docstring Wording for LDAP Documentation/Formatting Correction Wording and Error Handling Corrections
9d89c6c
to
a3cb5fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Defines database migrations, and adds report functionality and quote hiding.
Requirements:
Nice to have:
Resolves #58, resolves #47