Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview functions should start with Preview #55

Closed
wants to merge 1 commit into from
Closed

Preview functions should start with Preview #55

wants to merge 1 commit into from

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Jul 24, 2024

No description provided.

@Goooler Goooler marked this pull request as ready for review July 24, 2024 23:58
@Goooler Goooler mentioned this pull request Jul 25, 2024
Merged
@egorikftp
Copy link
Member

egorikftp commented Jul 25, 2024 •
edited
Loading

@Goooler why preview keyword should be at the beginning?
Didn't saw any official guidelines, but Google follow this name convention: https://developer.android.com/develop/ui/compose/tooling/previews

@Goooler
Copy link
Member Author

Goooler commented Jul 25, 2024

This was ever introduced in https://mrmans0n.github.io/compose-rules/rules/, maybe, but removed now.

Closing now, it's not much necessary.

@Goooler Goooler closed this Jul 25, 2024
@Goooler Goooler deleted the tweak-preview-functioin-generation branch July 25, 2024 06:38
@egorikftp
Copy link
Member

It was my feature request 😀

mrmans0n/compose-rules#229

@Goooler
Copy link
Member Author

Goooler commented Jul 25, 2024

Good to know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Goooler @egorikftp