Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rule groups_no_zero_gid_except_root #12720

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement rule groups_no_zero_gid_except_root #12720

wants to merge 2 commits into from
+67 −2

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Dec 16, 2024 •
edited
Loading

Description:

  • Implement rule groups_no_zero_gid_except_root
  • Rule checks that no group except root has GID of 0

Rationale:

  • Satisfies Ubuntu 24.04 CIS control 5.4.2.3

@mpurg mpurg requested a review from a team as a code owner December 16, 2024 07:47
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 16, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 16, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

ubuntu2404 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys added this to the 0.1.76 milestone Dec 16, 2024
@dodys dodys added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Dec 16, 2024
@dodys dodys self-assigned this Dec 16, 2024
mpurg added 2 commits December 16, 2024 15:18
@mpurg
Implement rule groups_no_zero_gid_except_root
d2529b4 
- checks that no group other than root has GID of 0
- manual remediation
- satisfies Ubuntu CIS 24.04 v1 5.4.2.3
@mpurg
Add rules to ubuntu2404 CIS control 5.4.2.3
470b1a8
@mpurg mpurg force-pushed the ubuntu2404_cis_5.4.2.3 branch from b04626e to 470b1a8 Compare December 16, 2024 14:22
@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 16, 2024

Code Climate has analyzed commit 470b1a8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys