fix two reproducible build issues #12696
Conversation
|
Hi @msmeissn. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Fixed two reproducible builds issues found by Bernhard Wiedemann. Signed-off-by: Marcus Meissner <[email protected]>
|
Code Climate has analyzed commit d843e3d and detected 3 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 50.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
| @@ -741,7 +742,7 @@ def _create_benchmark_xml_skeleton(self, env_yaml): | |||
| root.set('xml:lang', 'en-US') | |||
|
|
|||
| status = ET.SubElement(root, '{%s}status' % XCCDF12_NS) | |||
| status.set('date', datetime.date.today().strftime("%Y-%m-%d")) | |||
| status.set('date', time.strftime( "%Y-%m-%d", time.gmtime(int(os.environ.get('SOURCE_DATE_EPOCH', time.time()))))) | |||
There was a problem hiding this comment.
Please review the PEP8 finding on this line.
Fixed two reproducible builds issues found by Bernhard Wiedemann.
Description:
Rationale:
Review Hints: