ensure_logrotate_activated: Check timers.target.wants as well

[yuumasato]

Description:

• Expand check to also verify systemd timers.target.wants directory. Some systems may not have logrotate.timers defined in multi-user.target.wants.

Rationale:

• RHCOS4 has logrotate.timers included in timers.target.wants by default.
• From what I could check RHEL9 defines like that too.
• Fixes our CI runs: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-ComplianceAsCode-content-master-4.17-e2e-aws-rhcos4-high-weekly/1864452299477225472

    helpers.go:872: Result - Name: e2e-high-master-ensure-logrotate-activated - Status: FAIL - Severity: medium
    helpers.go:879: E2E-FAILURE: The expected remediated result for the e2e-high-master-ensure-logrotate-activated rule didn't match. Expected 'PASS', Got 'FAIL' 

• Follow up from: Update ensure_logrotate_activated for image mode #12645

Review Hints:

• Check that tests pass, :P

Additional information:

Debugging a 4.17 node:

sh-5.1# cat /etc/redhat-release 
Red Hat Enterprise Linux CoreOS release 4.17
sh-5.1# 
sh-5.1# file /etc/systemd/system/timers.target.wants/logrotate.timer
/etc/systemd/system/timers.target.wants/logrotate.timer: symbolic link to /usr/lib/systemd/system/logrotate.timer
sh-5.1# 
sh-5.1# file /etc/systemd/system/multi-user.target.wants/logrotate.timer
/etc/systemd/system/multi-user.target.wants/logrotate.timer: cannot open `/etc/systemd/system/multi-user.target.wants/logrotate.timer' (No such file or directory)

On 1minutetip machine:

[root@vm-10-0-186-171 ~]# cat /etc/redhat-release 
Red Hat Enterprise Linux release 9.6 Beta (Plow)
[root@vm-10-0-186-171 ~]# 
[root@vm-10-0-186-171 ~]# file /etc/systemd/system/timers.target.wants/logrotate.timer
/etc/systemd/system/timers.target.wants/logrotate.timer: symbolic link to /usr/lib/systemd/system/logrotate.timer
[root@vm-10-0-186-171 ~]# 
[root@vm-10-0-186-171 ~]# file /etc/systemd/system/multi-user.target.wants/logrotate.timer
/etc/systemd/system/multi-user.target.wants/logrotate.timer: cannot open `/etc/systemd/system/multi-user.target.wants/logrotate.timer' (No such file or directory)

• https://www.freedesktop.org/software/systemd/man/latest/bootup.html

[yuumasato]

/test 4.17-e2e-aws-rhcos4-high
/test 4.12-e2e-aws-rhcos4-high

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)

Fedora Testing Environment

Oracle Linux 8 Environment

[codeclimate]

Code Climate has analyzed commit a29b458 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

[rhmdnd]

/lgtm

[rhmdnd]

/test 4.14-images