Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules and vars to ubuntu2404 CIS control 5.1.16 #12667

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Add rules and vars to ubuntu2404 CIS control 5.1.16 #12667

merged 2 commits into from
Dec 4, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Dec 4, 2024

Description:

  • Add rules and vars to Ubuntu 24.04 CIS control 5.1.16 (Ensure sshd MaxAuthTries is configured)
  • Extend tests for rule sshd_set_max_auth_tries to test the logic that is unique to the rule

mpurg added 2 commits December 4, 2024 09:24
@mpurg
Add rules and vars to ubuntu2404 CIS control 5.1.16
364fa47
@mpurg
Extend tests for sshd_set_max_auth_tries
ee5a620 
Rule is not using the template oval because it requires
checking if value is in interval. Tests for this logic
were missing.
@mpurg mpurg requested a review from a team as a code owner December 4, 2024 08:29
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Dec 4, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 4, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Dec 4, 2024

Code Climate has analyzed commit ee5a620 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Dec 4, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. CIS CIS Benchmark related. labels Dec 4, 2024
@dodys dodys added this to the 0.1.76 milestone Dec 4, 2024
dodys
dodys approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit e58e9aa into ComplianceAsCode:master Dec 4, 2024
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys