Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new rule service_dhcpd6_disabled #12627

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 21, 2024

Description:

  • Add new rule service_dhcpd6_disabled based on service_dhcpd_disabled
  • Update control 2.1.5 in ubuntu2404 CIS profile (Ensure dhcp server services are not in use)
  • Define variable overrides for pkgname and servicename on ubuntu2404

Copy link

openshift-ci bot commented Nov 21, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 21, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff
New content has different text for rule 'xccdf_org.ssgproject.content_rule_service_dhcpd_disabled'.
--- xccdf_org.ssgproject.content_rule_service_dhcpd_disabled
+++ xccdf_org.ssgproject.content_rule_service_dhcpd_disabled
@@ -5,6 +5,7 @@
 [description]:
 The dhcpd service should be disabled on
 any system that does not need to act as a DHCP server.
+
 
 The dhcpd service can be disabled with the following command:
 $ sudo systemctl mask --now dhcpd.service

@Mab879 Mab879 added Ubuntu Ubuntu product related. New Rule Issues or pull requests related to new Rules. labels Nov 22, 2024
@Mab879 Mab879 added this to the 0.1.76 milestone Nov 22, 2024
@mpurg mpurg force-pushed the ubuntu2404_cis_2_1_3 branch from 23e744c to 1c507af Compare November 25, 2024 11:02
@mpurg mpurg requested a review from a team as a code owner November 25, 2024 11:02
@dodys dodys self-assigned this Nov 25, 2024
@mpurg mpurg force-pushed the ubuntu2404_cis_2_1_3 branch from 1c507af to a3af908 Compare November 25, 2024 12:04
Copy link

codeclimate bot commented Nov 25, 2024

Code Climate has analyzed commit a3af908 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit f940fb8 into ComplianceAsCode:master Nov 25, 2024
94 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ok-to-test Used by openshift-ci bot. New Rule Issues or pull requests related to new Rules. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants