Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dconf controls for Ubuntu 24.04 CIS #12622

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 19, 2024

Description:

  • Add/fix dconf rules and variables to Ubuntu 24.04 CIS controls to satisfy CIS recommendations 1.7.2 - 1.7.9
  • Also fix tests and typo in profile name

CIS value in login_banner_text variable was changed from
"Authorized uses" to "Authorized users" in 92b34e2.
@mpurg mpurg requested a review from a team as a code owner November 19, 2024 21:26
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 19, 2024
Copy link

openshift-ci bot commented Nov 19, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@mpurg mpurg changed the title Fix dconf rules in Ubuntu 24.04 CIS profile Fix dconf controls for Ubuntu 24.04 CIS Nov 20, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 21, 2024
@dodys dodys self-assigned this Nov 21, 2024
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Nov 21, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link

codeclimate bot commented Nov 21, 2024

Code Climate has analyzed commit 12d5331 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys merged commit f12c0f4 into ComplianceAsCode:master Nov 25, 2024
94 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants