Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CIS-specific banner rules for Ubuntu 24.04 CIS #12619

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 18, 2024

Description:

Switch to CIS-specific banner rules for Ubuntu 24.04 CIS:

  • banner_etc_motd_cis (CIS 1.6.1)
  • banner_etc_issue_cis (CIS 1.6.2)
  • banner_etc_issue_net_cis (CIS 1.6.3)

Draft until issues with oval_feed_url are resolved (#12617)

- banner_etc_motd_cis (CIS 1.6.1)
- banner_etc_issue_cis (CIS 1.6.2)
- banner_etc_issue_net_cis (CIS 1.6.3)
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 18, 2024
Copy link

openshift-ci bot commented Nov 18, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 18, 2024
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

codeclimate bot commented Nov 18, 2024

Code Climate has analyzed commit 7f775d9 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@mpurg mpurg marked this pull request as ready for review November 19, 2024 08:16
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Used by openshift-ci bot. label Nov 19, 2024
@dodys dodys self-assigned this Nov 25, 2024
@dodys dodys requested a review from a team November 25, 2024 15:22
@dodys dodys added CIS CIS Benchmark related. Ubuntu Ubuntu product related. labels Nov 25, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 25, 2024
@dodys dodys added the Update Profile Issues or pull requests related to Profiles updates. label Nov 25, 2024
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit 3f33bba into ComplianceAsCode:master Nov 25, 2024
93 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants