New rule kernel_config_modules #11558
Conversation
Add a rule that checks if support for kernel modules is disabled. If the system can function without support for kernel modules, the support for them should be disabled. Include the rule to ANSSI R23 as a related rule.
|
Start a new ephemeral environment with changes proposed in this pull request: rhel8 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
Code Climate has analyzed commit 1d295a4 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 58.4% (0.0% change). View more on Code Climate. |
| @@ -579,6 +579,9 @@ controls: | |||
| - kernel_config_hibernation | |||
| - kernel_config_binfmt_misc | |||
| - kernel_config_legacy_ptys | |||
| related_rules: | |||
| # This rule isn't included in any profile therefore it won't appear in the built data stream. | |||
There was a problem hiding this comment.
This comment, doesn't explain the why it here and not in the rules section. Please update this comment to reflect that.
I assume we wanted to create it to provide broader context in the controls file. But, I don't like it. The rule won't be present in the built data stream, so the rule is useless. |
This PR supersedes ComplianceAsCode#11558 where we discovered that if we create a special rule for CONFIG_MODULES and put it only to related_rules the rule won't be useful because it won't get into the built data stream.
|
replaced by #11571 |
This PR supersedes ComplianceAsCode#11558 where we discovered that if we create a special rule for CONFIG_MODULES and put it only to related_rules the rule won't be useful because it won't get into the built data stream.
Add a rule that checks if support for kernel modules is disabled. If the system can function without support for kernel modules, the support for them should be disabled. Include the rule to ANSSI R23 as a related rule.