Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T1844 change settings registration many2one to many2many #47

Conversation

jordyBSK
Copy link
Contributor

No description provided.

Copy link

sonarcloud bot commented Sep 27, 2024

Copy link
Member

@ecino ecino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, but unfortunately not the good solution. The task description was good but the code sending the notification is in fact not using this setting anymore! If you go here https://github.com/compassionch/compassion-website/blob/813778e43b9bf911f4af586a72af4cc62f672d6f/muskathlon/models/event_registration.py#L109-L111 you will see that the users notified are the one following the event.

So if Olivier wants multiple users to be notified on registrations, he should simply add them to the followers of the event:

image

Here in the code I would like you to remove completely the setting muskathlon_lead_notify_id which is not used anywhere in the code. And please keep the other setting muskathlon_order_notify_id as it was before, otherwise the web page for ordering flyers will not work anymore. Here it's not possible to have multiple users because it's connected with a crm.lead object user_id field which can only have one id.

@jordyBSK jordyBSK closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants