T1763 - Change how donations are displayed in cart #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ecino
requested changes
Sep 2, 2024
Comment on lines
+90
to
+94
| price = product.standard_price | ||
| if not quantity.is_integer(): | ||
| quantity = 1 | ||
| price = amount | ||
|
|
There was a problem hiding this comment.
This can be done regardless if the quantity is entire or not.
Suggested change
| price = product.standard_price | |
| if not quantity.is_integer(): | |
| quantity = 1 | |
| price = amount | |
| quantity = 1 | |
| price = amount |
PS: the line above can also be removed.
There was a problem hiding this comment.
But wouldn't it be weird if after selecting 3 toilet accesses it shows toilet accesses 1 for 90.- instead of toilet access 3? Or maybe also change the name of the product to 3 toilet accesses directly?
My change:
Your proposition:
New Proposition:
And maybe something like that for custom donations
There was a problem hiding this comment.
You are right, your changes make more sense :)
ecino
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the quantity is not a whole number, change the price to match and set the quantity to 1:
Otherwise, keep the same behavior: