Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T1537 - my compassion data protection #29

Merged
merged 2 commits into from
Aug 8, 2024
Merged

T1537 - my compassion data protection #29

merged 2 commits into from
Aug 8, 2024

Conversation

clementcharmillot
Copy link
Contributor

@clementcharmillot clementcharmillot commented Aug 5, 2024 •
edited
Loading

Add the possibility to sign the data privacy agreement inside the profile directly.

Clicking on the text next to the checkbox opens https://compassion.ch/protection-des-donnees/ in the user's language.

  • Preview my compassion:
    image
  • Preview muskathlon:
    image

@clementcharmillot clementcharmillot marked this pull request as ready for review August 5, 2024 11:35
@clementcharmillot clementcharmillot self-assigned this Aug 5, 2024
ecino
ecino requested changes Aug 8, 2024
View reviewed changes
Copy link
Member

@ecino ecino left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you :

  • Add a small top margin between the button and the upper text?
  • Have a shorter label in the button ("Sign the agreement" or just "Send")?
  • Provide the de,fr and it translations (you can use deepl if needed or ask the team)?

Thanks!

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@clementcharmillot
Copy link
Contributor Author

Thanks for the review.

The checkbox label comes from the login screen and already has a translation. I changed the button margin and text + translation:
image
image

@ecino ecino merged commit c7a7041 into 14.0 Aug 8, 2024
2 checks passed
@ecino ecino deleted the T1537-my-compassion-data-protection branch August 8, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecino ecino ecino approved these changes

Assignees

@clementcharmillot clementcharmillot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clementcharmillot @ecino