Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

14.0 my compassion #2

Merged
merged 4 commits into from
Nov 23, 2023
Merged

14.0 my compassion #2

merged 4 commits into from
Nov 23, 2023

Conversation

ecino
Copy link
Member

@ecino ecino commented Sep 5, 2023

No description provided.

@ecino ecino force-pushed the 14.0-my-compassion branch 3 times, most recently from a061895 to 8c4dede Compare September 12, 2023 14:03
@ecino ecino force-pushed the 14.0-my-compassion branch 3 times, most recently from e89ea57 to 7be07c1 Compare September 25, 2023 12:58
@ecino ecino marked this pull request as ready for review September 25, 2023 13:09
@ecino ecino force-pushed the 14.0-my-compassion branch 7 times, most recently from e2392fa to da76302 Compare September 25, 2023 15:12
- DEL auth signup requirements
- DEL livechat requirements
- DEL custom headers and robots
- DEL auto_texts for Christmas
- MOVE segmentation into a bridge module
- MOVE contact us form into a separate module to migrate (T0509)
- Use Odoo traditional signup process but inject partner search
  capability given a reference (child or sponsor)
@ecino ecino force-pushed the 14.0-my-compassion branch 2 times, most recently from 017fa70 to f7001a4 Compare November 23, 2023 09:09
Copy link

sonarcloud bot commented Nov 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

$(".christmas_action").toggleClass("d-none");
});
startStopLoading("sending");
function displayAlert(id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function displayAlert is duplicated in my_compassion/static/src/js/my_children.js:54
But as we talked, no need to take too much time on this code as we will get rid of it in version 2.0

@ecino ecino merged commit ffe2ee0 into 14.0 Nov 23, 2023
3 checks passed
@ecino ecino deleted the 14.0-my-compassion branch November 23, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants