T1889 cannot send letter on mycompassion (#53)

* Setup test infrastructure * Add warning if user tries to send/preview a letter with an empty text * Add translations for warning message * Simplify check * Remove useless tests * Fix pre-commit * Change alert warning->danger to be clearer to user * Update my_compassion/i18n/de.po Fix translation Sie -> Du Co-authored-by: ecino <[email protected]> --------- Co-authored-by: ecino <[email protected]>
CompassionCH · Nov 18, 2024 · bb4d4e5 · bb4d4e5
1 parent 2016776
commit bb4d4e5
Show file tree

Hide file tree

Showing 13 changed files with 68 additions and 33 deletions.
diff --git a/muskathlon/README.rst b/muskathlon/README.rst
@@ -24,11 +24,11 @@ Muskathlon
 
 Adds a website portal for Muskathlon Events :
 
--  list of events
--  event page with participants
--  donation
--  registration
--  runner portal
+- list of events
+- event page with participants
+- donation
+- registration
+- runner portal
 
 Reports for sending information to 4M: - list with useful data about the
 muskathlon event - bar graph amount by ambassador - fields format for a
@@ -60,10 +60,10 @@ Authors
 Contributors
 ------------
 
--  Sebastien Toth <[email protected]>
--  Nicolas Badoux
--  Samuel Fringeli
--  Emanuel Cino <[email protected]>
+- Sebastien Toth <[email protected]>
+- Nicolas Badoux
+- Samuel Fringeli
+- Emanuel Cino <[email protected]>
 
 Maintainers
 -----------

diff --git a/my_compassion/README.rst b/my_compassion/README.rst
@@ -50,9 +50,9 @@ Authors
 Contributors
 ------------
 
--  Sebastien Toth <[email protected]>
--  Christopher Meier <[email protected]>
--  Théo Nikles <[email protected]>
+- Sebastien Toth <[email protected]>
+- Christopher Meier <[email protected]>
+- Théo Nikles <[email protected]>
 
 Maintainers
 -----------

diff --git a/my_compassion/i18n/de.po b/my_compassion/i18n/de.po
@@ -764,6 +764,14 @@ msgstr ""
 "Wenn der Fehler weiterhin besteht, kontaktiere uns auf [email protected], "
 "damit wir das Problem lösen können."
 
+#. module: my_compassion
+#: model_terms:ir.ui.view,arch_db:my_compassion.letter_actions
+msgid ""
+"The text of your letter is empty. Please add some text and try again."
+msgstr ""
+"Der Text Deines Briefes ist leer."
+"Bitte füge Text hinzu und versuche es erneut."
+
 #. module: my_compassion
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_letters
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_pictures

diff --git a/my_compassion/i18n/fr_CH.po b/my_compassion/i18n/fr_CH.po
@@ -773,6 +773,13 @@ msgstr ""
 "Si l'erreur persiste, Merci de nous contacter à [email protected] pour nous "
 "signaler le problème."
 
+#. module: my_compassion
+#: model_terms:ir.ui.view,arch_db:my_compassion.letter_actions
+msgid ""
+"The text of your letter is empty. Please add some text and try again."
+msgstr ""
+"Le texte de votre lettre est vide. Veuillez ajouter du texte et réessayer."
+
 #. module: my_compassion
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_letters
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_pictures

diff --git a/my_compassion/i18n/it.po b/my_compassion/i18n/it.po
@@ -766,6 +766,13 @@ msgstr ""
 "perderlo e contattaci all'indirizzo [email protected] per segnalare il "
 "problema."
 
+#. module: my_compassion
+#: model_terms:ir.ui.view,arch_db:my_compassion.letter_actions
+msgid ""
+"The text of your letter is empty. Please add some text and try again."
+msgstr ""
+"Il testo della tua lettera è vuoto. Si prega di aggiungere del testo e riprovare."
+
 #. module: my_compassion
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_letters
 #: model_terms:ir.ui.view,arch_db:my_compassion.my_children_pictures

diff --git a/my_compassion/static/src/js/write_a_letter.js b/my_compassion/static/src/js/write_a_letter.js
@@ -258,6 +258,12 @@ function startStopLoading(type) {
  * we can send a letter directly if the user pressed the corresponding button
  */
 async function createLetter(mode = "preview") {
+  // Check if text is empty (and avoid sending the request if it is)
+  if (letter_content.value.length === 0) {
+    displayAlert("letter_text_empty_warning");
+    return;
+  }
+
   startStopLoading(mode);
   const params = new URLSearchParams(window.location.search);
 

diff --git a/my_compassion/templates/my_account_write_a_letter.xml b/my_compassion/templates/my_account_write_a_letter.xml
@@ -280,6 +280,13 @@
 
             </div>
             <div
+        id="letter_text_empty_warning"
+        class="alert alert-danger alert-dismissable text-center ml-2 mt-2 mb-2"
+        style="display: none;"
+      >
+                The text of your letter is empty. Please add some text and try again.
+            </div>
+            <div
         id="send_error"
         class="alert alert-danger alert-dismissable text-center ml-2 mt-2 mb-2"
         style="display: none;"

diff --git a/my_compassion_segmentation/README.rst b/my_compassion_segmentation/README.rst
@@ -51,7 +51,7 @@ Authors
 Contributors
 ------------
 
--  Emanuel Cino <[email protected]>
+- Emanuel Cino <[email protected]>
 
 Maintainers
 -----------

diff --git a/website_child_protection/README.rst b/website_child_protection/README.rst
@@ -51,7 +51,7 @@ Authors
 Contributors
 ------------
 
--  Emanuel Cino <[email protected]>
+- Emanuel Cino <[email protected]>
 
 Maintainers
 -----------

diff --git a/website_event_compassion/README.rst b/website_event_compassion/README.rst
@@ -42,20 +42,20 @@ To use this module, you need to:
 Known issues / Roadmap
 ======================
 
--  Nothing yet
+- Nothing yet
 
 Changelog
 =========
 
 10.0.1.0.0 (2018-07-12)
 -----------------------
 
--  [ADD] Add the module.
+- [ADD] Add the module.
 
 11.0.1.0.0 (2020-01-02)
 -----------------------
 
--  Migrated to Odoo v11.
+- Migrated to Odoo v11.
 
 Bug Tracker
 ===========
@@ -78,7 +78,7 @@ Authors
 Contributors
 ------------
 
--  Emanuel Cino <[email protected]>
+- Emanuel Cino <[email protected]>
 
 Maintainers
 -----------

diff --git a/website_sale_donation/README.rst b/website_sale_donation/README.rst
@@ -35,7 +35,7 @@ Changelog
 14.0.1.1.0
 ----------
 
--  [ADD] Automatically match partner during checkout.
+- [ADD] Automatically match partner during checkout.
 
 Bug Tracker
 ===========
@@ -58,7 +58,7 @@ Authors
 Contributors
 ------------
 
--  Emanuel Cino [email protected]
+- Emanuel Cino [email protected]
 
 Maintainers
 -----------

diff --git a/website_sponsorship/README.rst b/website_sponsorship/README.rst
@@ -33,11 +33,11 @@ any published child.
 Configuration
 =============
 
--  You can go on the website and edit the page templates in order to
-   make sure it fits your needs and design guidelines.
--  Under Sponsorship/Settings/Personal Data Agreement, you should create
-   a page for displaying the general terms that have to be accepted upon
-   making a new sponsorship.
+- You can go on the website and edit the page templates in order to make
+  sure it fits your needs and design guidelines.
+- Under Sponsorship/Settings/Personal Data Agreement, you should create
+  a page for displaying the general terms that have to be accepted upon
+  making a new sponsorship.
 
 Usage
 =====
@@ -47,15 +47,15 @@ website.
 
 Three new public routes will be added:
 
--  /children : public childpool
--  /child/<child_id>: child presentation page
--  /child/<child_id>/sponsor: child sponsorship form
--  /data-protection: data protection and general terms page
+- /children : public childpool
+- /child/<child_id>: child presentation page
+- /child/<child_id>/sponsor: child sponsorship form
+- /data-protection: data protection and general terms page
 
 Known issues / Roadmap
 ======================
 
--  T0433 : make a nice looking child description page
+- T0433 : make a nice looking child description page
 
 Bug Tracker
 ===========
@@ -78,7 +78,7 @@ Authors
 Contributors
 ------------
 
--  Emanuel Cino <[email protected]>
+- Emanuel Cino <[email protected]>
 
 Maintainers
 -----------

diff --git a/website_sponsorship/static/description/index.html b/website_sponsorship/static/description/index.html
@@ -390,8 +390,8 @@ <h1 class="title">Website - Sponsor a child form</h1>
 <div class="section" id="configuration">
 <h1><a class="toc-backref" href="#toc-entry-1">Configuration</a></h1>
 <ul class="simple">
-<li>You can go on the website and edit the page templates in order to
-make sure it fits your needs and design guidelines.</li>
+<li>You can go on the website and edit the page templates in order to make
+sure it fits your needs and design guidelines.</li>
 <li>Under Sponsorship/Settings/Personal Data Agreement, you should create
 a page for displaying the general terms that have to be accepted upon
 making a new sponsorship.</li>