Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge NLP module fixes/improvements #120

Merged
merged 17 commits into from
Jul 19, 2024
Merged

Merge NLP module fixes/improvements #120

merged 17 commits into from
Jul 19, 2024

Conversation

ronentk
Copy link
Contributor

@ronentk ronentk commented Jul 10, 2024

#116 - adding itemtype and quote tweet relations to parser semantics

thread trimming

#105 add thread trimming option
bug fix
#117

Copy link

gitguardian bot commented Jul 10, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11699671 Triggered Generic High Entropy Secret 976f162 nlp/notebooks/XdatasetLogEdit.ipynb View secret
12247943 Triggered Generic High Entropy Secret e7ec87f app/firebase/functions/test/tests/user.timeline.result.mock.json View secret
12247944 Triggered Generic High Entropy Secret 98f411e app/firebase/functions/test/tests/user.timeline.result.mock.json View secret
12247944 Triggered Generic High Entropy Secret e7ec87f app/firebase/functions/test/tests/user.timeline.result.mock.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

adds prevalidation for content and url fields of app posts to normalize twitter urls
@pepoospina pepoospina merged commit 4747b85 into development Jul 19, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants