Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dedication contact details to receipt emails #962

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

hejkal
Copy link

@hejkal hejkal commented Dec 12, 2024

NOTE: DO NOT discuss internal CommitChange information in your PR; this PR will be public.
Link back to the issue in the Tix repo when you need to do that.

closes https://github.com/CommitChange/tix/issues/4110

@hejkal hejkal requested a review from wwahammy as a code owner December 12, 2024 22:00
Copy link
Member

@wwahammy wwahammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wwahammy
Copy link
Member

@hejkal the tests seem to have failed though. Otherwise it looked good! 😆

@hejkal
Copy link
Author

hejkal commented Dec 12, 2024

@hejkal the tests seem to have failed though. Otherwise it looked good! 😆

@wwahammy Yep, there are tests failing that I thought weren't related, trying to figure that out

Copy link
Member

@wwahammy wwahammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested an idea that I think will clean this up a bit but YMMV.

app/views/donation_mailer/_donation_payment_table.html.erb Outdated Show resolved Hide resolved
@wwahammy wwahammy enabled auto-merge December 13, 2024 17:30
@wwahammy
Copy link
Member

Looks good @hejkal!

@wwahammy wwahammy merged commit 793efdd into supporter_level_goal Dec 13, 2024
4 of 5 checks passed
@wwahammy wwahammy deleted the dedication-contact-on-receipt-email branch December 13, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants