Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin transitioning generated code to Kotlin #60

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

dapp
Copy link
Collaborator

@dapp dapp commented Feb 12, 2021

WIP, not ready for merge

dapp added 6 commits February 12, 2021 13:08
Left the java files in for reference, temporarily
In AGP 5 (and currently for AARs), resource IDs are no
longer final, which means we can't use them in annotation
parameters the way we do with ComponentViewHolder

This commit changes the ComponentViewHolder annotation to
accept a String, which must be the name of the layout for the
view holder, so that blueprint can continue to function. Blueprint
will use the name of the layout to fabricate the layout id, and use
that the same way as before, for component view inflation and referencing.
@dapp dapp force-pushed the generate-kotlin branch from 005a75e to dfc5790 Compare March 12, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants