-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-language support for theming added (i.e. German) #48
base: main
Are you sure you want to change the base?
Conversation
@maehr we really like the idea of this PR. @owikle has been working on a multi-lingual version of CB-GH that uses javascript to actively switch between languages on one site that in some parts parallels your approach here. I think we might be able to combine the approaches to support a single language and building multi language versions. I know there is some other well translated examples in Spanish and Italian, so we could even seed it with some more default languages. |
Also, just wanted to say the work on the datatables translation is cool--a ton of data needed! I haven't seen that done for any custom examples yet. |
@evanwill thanks for reviewing my PR and to @owikle for working on the multilingual feature. Please let me know how you want to proceed. Best PS: I completely forgot to add documentation (and credits) for datatables localization. |
Thanks @maehr . |
Co-authored-by: Moritz Mähr <[email protected]>
Note: Due to the scope of this project, work on this feature has moved to a new prototype fork of CB-CSV, cb-translate. The content of this PR has been added to that repository. |
@evanwill Is it ok to |
* feat: trigger warning added * fix: add trigger warnings for browse * fix: more consitent layout
Dear team,
I have made some changes to the project that I believe will enhance the user experience for non-English speaking users. Specifically, I have added multi-language support for gui elements and datatables. Currently, only German language support is available, but this lays the foundation for supporting additional languages in the future.
Additionally, I have added documentation to help users understand how to change the language of the gui elements and datatables to their preferred language.
Please review these changes and let me know if you have any feedback or concerns. I believe that these improvements will make the product more accessible and user-friendly for our international customers.
Thank you for your time and consideration.
Best regards,
Moritz