Feat/gh 25/images form #62
Conversation
…nteam/collaction_cms into feat/gh-25/images-form
…ction_cms into feat/gh-25/images-form
|
Visit the preview URL for this PR (updated for commit 1fa7719): https://collaction-development--pr62-feat-gh-25-images-fo-v4xxm3yv.web.app (expires Tue, 11 Apr 2023 04:47:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2cf09e8dbf51d2eab3fc6679b673d248bc8047bb |
| widget.callback == null | ||
| ? null | ||
| : widget.callback!(_validationOutput.error ? null : _image); |
There was a problem hiding this comment.
I think that widget.callback?.call(_validationOutput.error ? null : _image) is cleaner in these cases
There was a problem hiding this comment.
Agreed, will make the change
| 'image/png', | ||
| ]; | ||
| late DropzoneViewController _controller; | ||
| late ValidationOutput _validationOutput; |
There was a problem hiding this comment.
If you trigger the button "Save CrowdAction" and the fields are empty a "late initialization error" is produced. This is because the ValidationOutput has not been initialized. One way to fix this is by adding a validation in initState like this:
void initState() {
// TODO: implement initState
super.initState();
widget.validationCallback == null
? _validationOutput = ValidationOutput(error: false)
: _validationOutput = widget.validationCallback!(_image);
}
| double cropperMargin = 30, | ||
| }) async { | ||
| CropController controller = CropController(); | ||
| double aspectRatio = targetSize.width / targetSize.height; |
There was a problem hiding this comment.
Size already has a getter called aspectRatio
https://api.flutter.dev/flutter/dart-ui/Size/aspectRatio.html
But it might be confusing to pass a ratio as a Size. People might expect to pass a width and height like Size(200, 50) etc. Might be better to create a class like Ratio() to avoid confusions.
There was a problem hiding this comment.
Did not know about the getter, thanks for letting me know.
As for use of Size, that was left over from before @laschnik proposed the use of standard 16:9. Looking at it again, it seems like double aspectRatio = 16 / 9 would be more suitable, since the code never uses the width/height components separately anyways.
Created the UI for uploading and cropping images. Closes #25.