Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: setup theme extensions #373

Closed

Conversation

wizlif
Copy link
Collaborator

@wizlif wizlif commented Mar 7, 2023

Refactor of #362
Closes #344

@wizlif wizlif requested review from Xazin, yasht01 and andre-tm-hui March 7, 2023 20:29
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Merging #373 (7b69c92) into development (6528ad6) will increase coverage by 0.40%.
The diff coverage is 69.41%.

@@               Coverage Diff               @@
##           development     #373      +/-   ##
===============================================
+ Coverage        65.63%   66.04%   +0.40%     
===============================================
  Files              161      167       +6     
  Lines             4065     4532     +467     
===============================================
+ Hits              2668     2993     +325     
- Misses            1397     1539     +142     
Impacted Files Coverage Δ
lib/presentation/auth/auth_screen.dart 1.81% <0.00%> (-0.19%) ⬇️
lib/presentation/auth/unauthenticated_screen.dart 0.00% <0.00%> (ø)
lib/presentation/core/app_widget.dart 0.00% <0.00%> (ø)
.../crowdaction_browse/crowdaction_browse_screen.dart 0.00% <0.00%> (ø)
...rowdaction_comments/crowdaction_comments_page.dart 2.50% <0.00%> (-0.07%) ⬇️
...action_comments/parts/comment_appbar_delegate.dart 3.70% <0.00%> (-0.15%) ⬇️
...ction/crowdaction_comments/parts/comment_item.dart 0.00% <0.00%> (ø)
.../crowdaction_comments/parts/comment_textfield.dart 10.00% <0.00%> (-10.00%) ⬇️
...ion/crowdaction_comments/widgets/flag_comment.dart 0.00% <0.00%> (ø)
...rowdaction_details/crowdaction_details_screen.dart 0.00% <0.00%> (ø)
... and 74 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wizlif wizlif force-pushed the core/setup-theme-extensions branch from 1663bc4 to 7b69c92 Compare March 30, 2023 16:34
@wizlif
Copy link
Collaborator Author

wizlif commented May 2, 2023

Themes will be handled from collaction_common package

@wizlif wizlif closed this May 2, 2023
@wizlif wizlif deleted the core/setup-theme-extensions branch May 5, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SUGGESTION]: Support for darkmode
1 participant