Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/application: refactoring mock classes #250

Open
wants to merge 10 commits into
base: development
Choose a base branch
from

Conversation

saksham-gt
Copy link
Collaborator

Declaring all mock classes in test utilities.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #250 (354fe58) into development (e7a984d) will increase coverage by 1.84%.
The diff coverage is 14.28%.

@@              Coverage Diff               @@
##           development    #250      +/-   ##
==============================================
+ Coverage         7.90%   9.75%   +1.84%     
==============================================
  Files              122     122              
  Lines             3401    3404       +3     
==============================================
+ Hits               269     332      +63     
+ Misses            3132    3072      -60     
Impacted Files Coverage Δ
lib/presentation/home/home_screen.dart 5.55% <0.00%> (ø)
...ib/presentation/shared_widgets/photo_selector.dart 0.00% <0.00%> (ø)
lib/domain/user/user.dart 100.00% <100.00%> (ø)
lib/application/user/profile/profile_state.dart 33.33% <0.00%> (+16.66%) ⬆️
lib/application/user/profile/profile_bloc.dart 23.07% <0.00%> (+23.07%) ⬆️
...ib/application/user_details/user_details_bloc.dart 91.66% <0.00%> (+91.66%) ⬆️
lib/domain/core/errors.dart 100.00% <0.00%> (+100.00%) ⬆️
lib/domain/auth/value_objects.dart 100.00% <0.00%> (+100.00%) ⬆️
lib/domain/core/value_objects.dart 100.00% <0.00%> (+100.00%) ⬆️
lib/domain/auth/value_validators.dart 100.00% <0.00%> (+100.00%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@saksham-gt saksham-gt requested a review from Xazin June 24, 2022 18:05
Copy link

@obella425 obella425 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general comment, could these tests be split to their individual P.Rs instead of lumping them together

@Xazin
Copy link
Member

Xazin commented Oct 19, 2022

Merge conflicts - needs rebase

@Xazin Xazin force-pushed the development branch 13 times, most recently from 5be7e86 to 77ff369 Compare December 11, 2022 20:08
@Xazin Xazin force-pushed the development branch 10 times, most recently from 05db9fc to 1ac5990 Compare December 19, 2022 21:36
@Xazin
Copy link
Member

Xazin commented Feb 8, 2023

@glitchpop-frenzy 👀

@saksham-gt
Copy link
Collaborator Author

Noted, will do it this week! 😄

@Xazin Xazin force-pushed the development branch 2 times, most recently from 8906c8d to 649893f Compare March 4, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants